added-binary-arithmetic-operators-logical-operators-topk #723
Conversation
|
@bboreham sir, can you kindly approve it so that it can be merged? |
|
This needs a DCO sign-off. You can use |
| interval: 15s | ||
| type: instant | ||
| queries: | ||
| - expr: sum(node_memory_MemAvailable_bytes) / sum(node_memory_MemTotal_bytes) |
There was a problem hiding this comment.
I checked a running Prombench, and there are only 3 series like this; perhaps not great for a benchmark.
There was a problem hiding this comment.
@bboreham Hi Sir, I hope you are doing well. First of all, sorry for the late reply. I'm also really glad that you liked my #743 PR.
So, now that I'm focusing on this, here are some of the suggested changes from my side. PTAL once so I can create a commit and merge it.
- name: binary_arithmetic_operators
interval: 15s
type: instant
queries:
- expr: sum(rate(codelab_api_requests_total[5m])) / count(codelab_api_requests_total)
- expr: rate(codelab_api_request_duration_seconds_count[5m]) * 60
- expr: codelab_api_request_duration_seconds_sum / codelab_api_request_duration_seconds_count
As suggested by you, I have made changes, PTAL.
| interval: 15s | ||
| type: instant | ||
| queries: | ||
| - expr: topk(5, rate(http_requests_total[5m])) |
There was a problem hiding this comment.
I couldn't find any of these in Prombench. Where would this metric come from?
There was a problem hiding this comment.
Some more proposed changes:
- name: logical_operators
interval: 15s
type: instant
queries:
- expr: rate(codelab_api_requests_total{method="GET"}[5m]) and rate(codelab_api_requests_total{method="POST"}[5m])
- expr: codelab_api_requests_total unless codelab_api_request_errors_total
- expr: rate(codelab_api_requests_total[5m]) or rate(codelab_api_request_errors_total[5m])
- name: topk_example
interval: 15s
type: instant
queries:
- expr: topk(5, sum by(method, path) (rate(codelab_api_requests_total[5m])))
|
For reference, I copied this from http://prombench.prometheus.io/14920/prometheus-release/tsdb-status: Top 10 series count by metric names
|
|
@bboreham Hi Sir, hope you are doing well, thanks for your reply, currently I am having my university exams till the end of this month, so not able to look into this matter for now, but as soon as it will end, I will review it properly and make appropriate changes. Hope you understand. |
|
No problem; I think @kushalShukla-web is going to take a look. |
|
This was overtaken by #747. Thanks for your contribution! |
Modified the 6_loadgen.yaml file to include tests for the additional PromQL features mentioned in the issue: